This repository has been archived by the owner on Jan 13, 2022. It is now read-only.
Mark reference arguments at the call site #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HHVM 3.24 requires the reference arguments to be marked at the call site, following which the current oss-performance code throws errors when "hh_client" is run or the workload is run using HHVM runtime. This patch fixes the issue by marking the reference arguments at the call time. However, this patch also mandates the HHVM version to be at least 3.24 and makes it incompatible with the earlier versions as the change is not supported in earlier versions of HHVM Fixes facebookarchive#89
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HHVM 3.24 requires the reference arguments to be marked at the call site, following which the current oss-performance code throws errors when
"hh_client" is run or the workload is run using HHVM runtime. This patch fixes the issue by marking the reference arguments at the call time.
However, this patch also mandates the HHVM version to be at least 3.24 and makes it incompatible with the earlier versions as the change is
not supported in earlier versions of HHVM
Fixes #89